On 16/07/2022 11:44, Marc Zyngier wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > A couple of other nits: > >> +static const struct of_device_id mpfs_of_ids[] = { >> + { .compatible = "microchip,mpfs-gpio", }, > > Where is the DT binding for this? > Upstreamed with the device tree entry in 5.18: Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml Lewis: might be worth mentioning that in your cover letters. Thanks, Conor.