Re: [PATCH v2 1/1] gpio: mpfs: add polarfire soc gpio support

[<Conor.Dooley@xxxxxxxxxxxxx>]

On 13/07/2022 23:14, Andy Shevchenko wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Wed, Jul 13, 2022 at 10:44 PM <Lewis.Hanly@xxxxxxxxxxxxx> wrote:
>> On Wed, 2022-07-13 at 13:59 +0200, Andy Shevchenko wrote:
>>> On Wed, Jul 13, 2022 at 1:00 PM <lewis.hanly@xxxxxxxxxxxxx> wrote:
>>>> +       if (gpio_cfg & MPFS_GPIO_EN_IN)
>>>> +               return 1;
>>>> +
>>>> +       return 0;
>>>
>>> Don't we have specific definitions for the directions?
>> No defines in file.
> 
> We have. Please, check again.

I said what they were on another reply Lewis:
https://elixir.bootlin.com/linux/latest/source/include/linux/gpio/driver.h#L25