Re: [PATCH 1/4] gpiolib: add support for bias pull disable

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Wed, Jul 13, 2022 at 03:14:18PM +0200, Nuno Sá wrote:
> This change prepares the gpio core to look at firmware flags and set
> 'FLAG_BIAS_DISABLE' if necessary. It works in similar way to
> 'GPIO_PULL_DOWN' and 'GPIO_PULL_UP'.

...

>  	GPIO_PULL_UP			= (1 << 4),
>  	GPIO_PULL_DOWN			= (1 << 5),
> +	GPIO_PULL_DISABLE		= (1 << 6),

To me it seems superfluous. You have already two flags:
PUp
PDown
When none is set --> Pdisable

-- 
With Best Regards,
Andy Shevchenko