Re: [PATCH v2 1/6] gpio: i8255: Introduce the i8255 module

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Fri, Jul 8, 2022 at 1:16 AM William Breathitt Gray
<william.gray@xxxxxxxxxx> wrote:

> Exposes consumer functions providing support for Intel 8255 Programmable
> Peripheral Interface devices. A CONFIG_GPIO_I8255 Kconfig option is
> introduced; modules wanting access to these functions should select this
> Kconfig option.
>
> Tested-by: Fred Eckert <Frede@xxxxxxxxxxxx>
> Cc: John Hentges <jhentges@xxxxxxxxxxx>
> Cc: Jay Dolan <jay.dolan@xxxxxxxxxxx>
> Signed-off-by: William Breathitt Gray <william.gray@xxxxxxxxxx>

This chip is like 50 years old, but so am I and I am not obsolete, it's about
time that we implement a proper driver for it!

But I suppose you are not really using the actual discrete i8255 component?
This is certainly used as integrated into some bridge or so? (Should be
mentioned in the commit.)

> +config GPIO_I8255
> +       tristate

That's a bit terse :D Explain that this is a Intel 8255 PPI chip first developed
in the first half of the 1970ies.

> +++ b/include/linux/gpio/i8255.h

You need to provide a rationale for the separate .h file in the commit
message even if it is clear
how it is used in the following patches.

Yours,
Linus Walleij