Re: [PATCH] gpio: rockchip: Fix missing of_node_put() in rockchip_gpio_probe() and rockchip_gpiolib_register()

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Wed, Jul 6, 2022 at 8:29 AM Liang He <windhl@xxxxxxx> wrote:
>
> We should call of_node_put() for the reference returned by
> of_get_parent() which will increase the refcount.

Is it suggested by the so-called Hulk Robot? If so, it's not the first
time I see that people don't think about, and just repeat as robots
do. Have you read the code? Have you tried to understand what may
happen when you put an OF node? What would be possible consequences to
the rest of the code?

The above sentence is correct, implementation is not thought through.
It might be a correct fix, but the commit message doesn't show that
you really spent time on the change.

P.S> I would personally put all those Hulk Robot bla-bla-bla with
lowest priority to consider, too many broken submissions...

-- 
With Best Regards,
Andy Shevchenko