Re: [PATCH gpio] gpio: vf610: fix compilation error

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Tue, Jul 5, 2022 at 12:21 PM Tariq Toukan <tariqt@xxxxxxxxxx> wrote:
>
> From: Leon Romanovsky <leonro@xxxxxxxxxx>
>
> Fix compilation error by explicitly adding the missing include.
>
> drivers/gpio/gpio-vf610.c: In function ‘vf610_gpio_direction_input’:
> drivers/gpio/gpio-vf610.c:120:9: error: implicit declaration of function ‘pinctrl_gpio_direction_input’; did you mean ‘vf610_gpio_direction_input’? [-Werror=implicit-function-declaration]
>   120 |  return pinctrl_gpio_direction_input(chip->base + gpio);
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |         vf610_gpio_direction_input


Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

> Fixes: 30a35c07d9e9 ("gpio: vf610: drop the SOC_VF610 dependency for GPIO_VF610")
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>
> Signed-off-by: Tariq Toukan <tariqt@xxxxxxxxxx>
> ---
>  drivers/gpio/gpio-vf610.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
> index 23cddb265a0d..9db42f6a2043 100644
> --- a/drivers/gpio/gpio-vf610.c
> +++ b/drivers/gpio/gpio-vf610.c
> @@ -19,6 +19,7 @@
>  #include <linux/of.h>
>  #include <linux/of_device.h>
>  #include <linux/of_irq.h>
> +#include <linux/pinctrl/consumer.h>
>
>  #define VF610_GPIO_PER_PORT            32
>
> --
> 2.21.0
>


-- 
With Best Regards,
Andy Shevchenko