Re: Compilation failure in gpio-vf610.c

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Tue, Jul 5, 2022 at 9:01 AM Tariq Toukan <ttoukan.linux@xxxxxxxxx> wrote:

> Recently we started seeing the compilation error:
>
> drivers/gpio/gpio-vf610.c: In function ‘vf610_gpio_direction_input’:
> drivers/gpio/gpio-vf610.c:120:9: error: implicit declaration of function
> ‘pinctrl_gpio_direction_input’; did you mean
> ‘vf610_gpio_direction_input’? [-Werror=implicit-function-declaration]
>    120 |  return pinctrl_gpio_direction_input(chip->base + gpio);
>        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>        |         vf610_gpio_direction_input
>
>
> Is it a known issue? Is there a fix we can cherry-pick?
>
> Offending patch:
>
> commit 30a35c07d9e9affaebd557c454df98e5ba269776
> Author: Peng Fan <peng.fan@xxxxxxx>
> Date:   Mon Apr 25 19:11:35 2022 +0800
>
>      gpio: vf610: drop the SOC_VF610 dependency for GPIO_VF610
>
>      i.MX7ULP, i.MX8 and i.MX9 use this driver, so drop
>      the SOC_VF610 dependcy to make the driver could be built
>      for i.MX platform.
>
>      Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
>      Signed-off-by: Bartosz Golaszewski <brgl@xxxxxxxx>
>
> This seems to solve the issue.
> Is it the proper way for solving this?
>
> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
> index 23cddb265a0d..9db42f6a2043 100644
> --- a/drivers/gpio/gpio-vf610.c
> +++ b/drivers/gpio/gpio-vf610.c
> @@ -19,6 +19,7 @@
>   #include <linux/of.h>
>   #include <linux/of_device.h>
>   #include <linux/of_irq.h>
> +#include <linux/pinctrl/consumer.h>
>
>   #define VF610_GPIO_PER_PORT            32

Missed header is an issue. The rule of thumb is to include headers we
are direct users of. Your fix is legit in my opinion. Can you submit a
formal patch with the Fixes tag added?


-- 
With Best Regards,
Andy Shevchenko