Re: [PATCH 2/2] gpio: Add support for SLG7XL45106 I2C GPO expander

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Tue, Jun 28, 2022 at 4:35 PM Shubhrajyoti Datta
<shubhrajyoti.datta@xxxxxxxxxx> wrote:
>
> From: Raviteja Narayanam <raviteja.narayanam@xxxxxxxxxx>
>
> Dialog semiconductors SLG7XL45106 is an 8-bit I2C GPO expander.
> The output port is controlled by a data byte with register
> address.

1/ Have you checked if there is a driver that sounds very similar to
this already upstream?
2/ Have you tried to use gpio-regmap? Why can it not be used?

...

> +struct slg7xl45106 {
> +       struct gpio_chip chip;

> +       struct mutex lock;      /* To protect writes */

If you switch to regmap I believe this entire struct will be gone completely.

> +};

-- 
With Best Regards,
Andy Shevchenko