Re: [PATCH] pinctrl: qcom: sc7280: Fix compile bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 6/27/2022 2:54 PM, Linus Walleij wrote:
Thanks for Your Support Linus.
The idea was right but the code was breaking in next.
I assume some unstaged commit was involed. Fix it up.

Cc: Srinivasa Rao Mandadapu <quic_srivasam@xxxxxxxxxxx>
Cc: Stephen Boyd <swboyd@xxxxxxxxxxxx>
Fixes: 36fe26843d6d ("pinctrl: qcom: sc7280: Add clock optional check for ADSP bypass targets")
Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
---
  drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
index b3d4244a5266..b5d1b996c454 100644
--- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
+++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
@@ -388,7 +388,8 @@ int lpi_pinctrl_probe(struct platform_device *pdev)
  	pctrl->data = data;
  	pctrl->dev = &pdev->dev;
- data->is_clk_optional = of_property_read_bool(np, "qcom,adsp-bypass-mode");
+	data->is_clk_optional = of_property_read_bool(dev->of_node,
+						      "qcom,adsp-bypass-mode");

There is another problem with this patch.  As lpi_pinctrl_variant_data is const type,  unable to update this variable.

So I have posted the fix patch series v5. Please check and let me me if anything to be done.

pctrl->clks[0].id = "core";
  	pctrl->clks[1].id = "audio";



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux