Re: [PATCH v2 1/5] pinctrl: mediatek: add generic driving setup property on mt8192

[Guodong Liu <guodong.liu@xxxxxxxxxxxx>]

-----Original Message-----
From: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
To: Guodong Liu <guodong.liu@xxxxxxxxxxxx>
Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>, Rob Herring <
robh+dt@xxxxxxxxxx>, Matthias Brugger <matthias.bgg@xxxxxxxxx>, Sean
Wang <sean.wang@xxxxxxxxxx>, Sean Wang <sean.wang@xxxxxxxxxxxx>,
Zhiyong Tao <zhiyong.tao@xxxxxxxxxxxx>, linux-gpio@xxxxxxxxxxxxxxx, 
devicetree@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, 
linux-mediatek@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, 
Project_Global_Chrome_Upstream_Group@xxxxxxxxxxxx
Subject: Re: [PATCH v2 1/5] pinctrl: mediatek: add generic driving
setup property on mt8192
Date: Fri, 24 Jun 2022 11:52:24 -0400

Hi Guodong,

please see comments below.

On Fri, Jun 24, 2022 at 09:36:56PM +0800, Guodong Liu wrote:
> 1. The dt-binding expects that drive-strength arguments be passed
> in mA, but the driver was expecting raw values. And that this
> commit changes the driver so that it is aligned with the binding.
> 2. This commit provides generic driving setup, which support
> 2/4/6/8/10/12/14/16mA driving, original driver just set raw data
> setup setting when use drive-strength property.

This commit message is a bit confusing, I suggest using the following
commit
message instead:

The dt-binding expects the drive-strength arguments to be passed in mA,
but the
driver was using callbacks that expect raw values instead. Change the
callbacks
for the ones that operate on mA values, so that the driver is in
accordance to
the dt-binding.

The drive-strength property requiring values in mA is the standard and
other
MediaTek SoCs of the same generation already do the same, so this
change avoids
mt8192 having a non-standard property.

There are no current upstream users of this driver, so this change
doesn't cause
any regression.

Fixed in next patch, thanks!

> 
> Signed-off-by: Guodong Liu <guodong.liu@xxxxxxxxxxxx>

Reviewed-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
Tested-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>

Thanks,
Nícolas