Re: [PATCH v5 09/14] dt-bindings: watchdog: Add fsl,scu-wdt yaml file

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 16/06/2022 18:42, Viorel Suman wrote:
> From: Abel Vesa <abel.vesa@xxxxxxx>
> 
> In order to replace the fsl,scu txt file from bindings/arm/freescale,
> we need to split it between the right subsystems. This patch documents
> separately the 'watchdog' child node of the SCU main node.
> 
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxx>
> Signed-off-by: Viorel Suman <viorel.suman@xxxxxxx>
> ---
>  .../bindings/watchdog/fsl,scu-wdt.yaml        | 35 +++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml
> new file mode 100644
> index 000000000000..c5d3063a4130
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/fsl,scu-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: i.MX SCU Client Device Node - Watchdog bindings based on SCU Message Protocol
> +
> +maintainers:
> +  - Dong Aisheng <aisheng.dong@xxxxxxx>
> +
> +description: i.MX SCU Client Device Node
> +  Client nodes are maintained as children of the relevant IMX-SCU device node.
> +
> +allOf:
> +  - $ref: /schemas/watchdog/watchdog.yaml

Blank line

> +properties:
> +  compatible:
> +    items:
> +      - const: fsl,imx8qxp-sc-wdt
> +      - const: fsl,imx-sc-wdt
> +
> +  timeout-sec: true

Drop it.

> +
> +required:
> +  - compatible
> +
> +additionalProperties: false

unevaluatedProperties: false

> +
> +examples:
> +  - |
> +    watchdog {
> +             compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt";

Indentation...

> +             timeout-sec = <60>;
> +    };


Best regards,
Krzysztof