Re: [PATCH v5 03/14] dt-bindings: pinctrl: imx: Add fsl,scu-iomux yaml file

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 16/06/2022 18:42, Viorel Suman wrote:
> From: Abel Vesa <abel.vesa@xxxxxxx>
> 
> In order to replace the fsl,scu txt file from bindings/arm/freescale,
> we need to split it between the right subsystems. This patch documents
> separately the 'iomux/pinctrl' child node of the SCU main node.
> 
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxx>
> Signed-off-by: Viorel Suman <viorel.suman@xxxxxxx>
> ---
>  .../bindings/pinctrl/fsl,scu-pinctrl.yaml     | 47 +++++++++++++++++++

Since this is a conversion, I expect removal of existing bindings. This
applies to each other patch as well.

>  1 file changed, 47 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml
> new file mode 100644
> index 000000000000..7a08c60da66f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/fsl,scu-pinctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: i.MX SCU Client Device Node - Pinctrl bindings based on SCU Message Protocol
> +
> +maintainers:
> +  - Dong Aisheng <aisheng.dong@xxxxxxx>
> +
> +description: i.MX SCU Client Device Node
> +  Client nodes are maintained as children of the relevant IMX-SCU device node.
> +  This binding uses the i.MX common pinctrl binding.
> +  (Documentation/devicetree/bindings/pinctrl/fsl,imx-pinctrl.txt)
> +
> +properties:
> +  compatible:
> +    items:

You have only one item, so no items.

> +      - enum:
> +          - fsl,imx8qm-iomuxc
> +          - fsl,imx8qxp-iomuxc
> +          - fsl,imx8dxl-iomuxc
> +
> +patternProperties:
> +  "grp$":
> +    type: object

You need to describe the children and then additionalProperties:false.
See other pinctrl bindings for example.

> +
> +required:
> +  - compatible
> +

Missing allOf referencing pinctrl.

> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/pinctrl/pads-imx8qxp.h>
> +
> +    pinctrl {
> +             compatible = "fsl,imx8qxp-iomuxc";
> +
> +             pinctrl_lpuart0: lpuart0grp {
> +                    fsl,pins = <
> +                            IMX8QXP_UART0_RX_ADMA_UART0_RX   0x06000020
> +                            IMX8QXP_UART0_TX_ADMA_UART0_TX   0x06000020
> +                    >;
> +             };
> +    };


Best regards,
Krzysztof