Re: [PATCH 2/2] gpio: twl4030: Don't return an error after WARN in .remove

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 14, 2022 at 5:23 PM Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
>
> Returning a non-zero value in a platform driver's remove callback only
> results in an error message ("remove callback returned a non-zero value.
> This will be ignored.", see platform_remove()), and then the device is
> removed anyhow.
>
> As there was just a WARN_ON triggered, return 0 to drop the follow up
> warning. The latter output is hardly relevant after the big WARN splat.
>
> This is a preparation for making platform remove callbacks return void.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---

Applied, thanks!

Bart




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux