Re: [PATCH v3 07/21] pinctrl: renesas: r8a779g0: remove not used MOD_SELx definitions

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Morimoto-san,

On Tue, Jun 21, 2022 at 2:12 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> > > Current V4H PFC code has many MOD_SELx definitions with all 0.
> > > But these have no meaning. This patch removes these, but keep
> > > its definition to avoid unreadable PINMUX_MOD_SELS.
> >
> > You can just replace them with blanks, keeping the structure of the
> > PINMUX_MOD_SELS table alive.
>
> Sorry, but I don't understand this. Maybe "blanks" and "alive".

blanks = TABs, i.e. a hole in the table structure
perhaps s/alive/intact/?

> Do you mean
> 1) "remove unnecessary MOD_SELx, and update PINMUX_MOD_SELS table"
>    (= need update on v4)
>
> or
>
> 2) "use NULL #define, and keep PINMUX_MOD_SELS" (= no update on v4)

I meant 1).

E.g.

-#define MOD_SEL7_1

and

-MOD_SEL4_1             MOD_SEL5_1              MOD_SEL6_1
 MOD_SEL7_1              MOD_SEL8_1      \
+MOD_SEL4_1             MOD_SEL5_1              MOD_SEL6_1
                         MOD_SEL8_1      \

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds