Re: [PATCH v3 08/21] pinctrl: renesas: r8a779g0: tidyup ioctrl_regs

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Morimoto-san,

On Tue, Jun 14, 2022 at 7:59 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>
> This patch comment out POC2 which is not used/documented,
> and remove TD0SEL3 which is no need to have.
>
> Reported-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/pinctrl/renesas/pfc-r8a779g0.c
> +++ b/drivers/pinctrl/renesas/pfc-r8a779g0.c
> @@ -3657,27 +3657,25 @@ static const struct pinmux_drive_reg pinmux_drive_regs[] = {
>  enum ioctrl_regs {
>         POC0,
>         POC1,
> -       POC2,
> +/*     POC2, is not used */

Please drop it completely, as POC2 is not documented to exist at all
(unlike TD0SEL3).

>         POC3,
>         POC4,
>         POC5,
>         POC6,
>         POC7,
>         POC8,
> -       TD0SEL3,
>  };
>
>  static const struct pinmux_ioctrl_reg pinmux_ioctrl_regs[] = {
>         [POC0]          = { 0xE60500A0, },
>         [POC1]          = { 0xE60508A0, },
> -       [POC2]          = { 0xE60580A0, },
> +/*     [POC2]          = { 0xE60580A0, }, is not used */
>         [POC3]          = { 0xE60588A0, },
>         [POC4]          = { 0xE60600A0, },
>         [POC5]          = { 0xE60608A0, },
>         [POC6]          = { 0xE60610A0, },
>         [POC7]          = { 0xE60618A0, },
>         [POC8]          = { 0xE60680A0, },
> -       [TD0SEL3]       = { 0xE60589C0, },
>         { /* sentinel */ },
>  };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds