Dne sreda, 15. junij 2022 ob 15:17:55 CEST je Linus Walleij napisal(a): > On Wed, May 25, 2022 at 9:08 PM Andrei Lalaev <andrey.lalaev@xxxxxxxxx> wrote: > > > Some Allwinner SoCs have 2 pinctrls (PIO and R_PIO). > > Previous implementation used absolute pin numbering and it was incorrect > > for R_PIO pinctrl. > > It's necessary to take into account the base pin number. > > > > Fixes: 90be64e27621 ("pinctrl: sunxi: implement pin_config_set") > > Signed-off-by: Andrei Lalaev <andrey.lalaev@xxxxxxxxx> > > It fixes a patch by Maxime so want Maxime to ACK this if it should be > applied. Paging Andre and Yangtao too, would be sad if we don't apply it > if it is a necessary fix. >From what I can see, this fixes makes code consistent with pattern in other functions, so I think it's good. Best regards, Jernej