Hello,
On Fri, May 27, 2022 at 09:11:36AM +0200, Uwe Kleine-König wrote:
> Hello,
>
> On Thu, May 05, 2022 at 02:44:40PM +0200, Bartosz Golaszewski wrote:
> > On Mon, May 2, 2022 at 7:06 PM Uwe Kleine-König
> > <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> > >
> > > All platforms that provide a teardown callback return 0. New users are
> > > supposed to not make use of platform support, so there is no
> > > functionality lost.
> > >
> > > This patch is a preparation for making i2c remove callbacks return void.
> > >
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > > ---
> >
> > Looks good to me.
> >
> > Sekhar: please leave your Ack if you're fine with me taking this
> > through the GPIO tree.
>
> Sekhar: Did this patch fell through the cracks? Would be great to get
> this in during the next merge window (i.e. depending on Linus Torvald's
> counting abilities maybe the one for 5.20)
I want to use the release of 5.19-rc1 as an opportunity to ping this
patch. I intend to change the i2c remove callback to return void (i.e.
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index fbda5ada2afc..066b541a0d5d 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -273,7 +273,7 @@ struct i2c_driver {
/* Standard driver model interfaces */
int (*probe)(struct i2c_client *client, const struct i2c_device_id *id);
- int (*remove)(struct i2c_client *client);
+ void (*remove)(struct i2c_client *client);
/* New driver model interface to aid the seamless removal of the
* current probe()'s, more commonly unused than used second parameter.
) directly after the next merge window.
So I ask you to either take this patch before (my preferred option), or
accept that I send it as part of a bigger series that eventually
contains the above hunk and will probably be merged via the i2c tree.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
