Re: [PATCH v5 1/6] pinctrl: Add pingroup and define PINCTRL_PINGROUP

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Wed, Jun 01, 2022 at 05:44:33PM +0530, Basavaraj Natikar wrote:
> Add 'struct pingroup' to represent pingroup and 'PINCTRL_PINGROUP'
> macro for inline use. Both are used to manage and represent
> larger number of pingroups.

LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Thanks!

> Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@xxxxxxx>
> ---
>  include/linux/pinctrl/pinctrl.h | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/include/linux/pinctrl/pinctrl.h b/include/linux/pinctrl/pinctrl.h
> index 70b45d28e7a9..487117ccb1bc 100644
> --- a/include/linux/pinctrl/pinctrl.h
> +++ b/include/linux/pinctrl/pinctrl.h
> @@ -26,6 +26,26 @@ struct pin_config_item;
>  struct gpio_chip;
>  struct device_node;
>  
> +/**
> + * struct pingroup - provides information on pingroup
> + * @name: a name for pingroup
> + * @pins: an array of pins in the pingroup
> + * @npins: number of pins in the pingroup
> + */
> +struct pingroup {
> +	const char *name;
> +	const unsigned int *pins;
> +	size_t npins;
> +};
> +
> +/* Convenience macro to define a single named or anonymous pingroup */
> +#define PINCTRL_PINGROUP(_name, _pins, _npins)	\
> +(struct pingroup){				\
> +	.name = _name,				\
> +	.pins = _pins,				\
> +	.npins = _npins,			\
> +}
> +
>  /**
>   * struct pinctrl_pin_desc - boards/machines provide information on their
>   * pins, pads or other muxable units in this struct
> -- 
> 2.25.1
> 

-- 
With Best Regards,
Andy Shevchenko