Re: [PATCH v4 6/6] pinctrl: amd: Implement pinmux functionality

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Wed, Jun 01, 2022 at 03:32:14PM +0530, Basavaraj Natikar wrote:
> Provide pinmux functionality by implementing pinmux_ops.

...

> +	if (!gpio_dev->iomux_base) {
> +		dev_warn(&gpio_dev->pdev->dev, "iomux function %d group not supported\n", selector);
> +		return -EINVAL;

In all cases like this, why dev_warn()? This message level is inconsistent with
the code flow, i.e. 'warn' means "tell and go on", 'err' - "tell and fail
execution".

> +	}

-- 
With Best Regards,
Andy Shevchenko