Re: [PATCH v3 4/6] pinctrl: amd: Define and use AMD_PINS macro

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Tue, May 31, 2022 at 5:27 PM Basavaraj Natikar <bnatikar@xxxxxxx> wrote:
> On 5/31/2022 3:53 PM, Andy Shevchenko wrote:
> > On Tue, May 31, 2022 at 02:13:20PM +0530, Basavaraj Natikar wrote:

...

> >> +#define AMD_PINS(...) ((const unsigned int []){__VA_ARGS__})
> > Do you need to have it as GCC expression?
>
> yes, or else I will hit the checkpatch error as below

Does it compile? Does it work? If so, fix checkpatch.

> ----------------------------------------------------
> ERROR: Macros with complex values should be enclosed in parentheses
> #31: FILE: drivers/pinctrl/pinctrl-amd.h:285:
> +#define AMD_PINS(...) (const unsigned int []){__VA_ARGS__}


-- 
With Best Regards,
Andy Shevchenko