Re: [PATCH v2 2/3] pinctrl: amd: Get and update IOMUX details

[Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>]

On Tue, May 24, 2022 at 05:22:47PM +0530, Basavaraj Natikar wrote:
> 
> On 5/24/2022 5:07 PM, Mika Westerberg wrote:
> 
> > Hi,
> >
> > On Tue, May 24, 2022 at 04:48:03PM +0530, Basavaraj Natikar wrote:
> >>>> +
> >>>> +       status = acpi_walk_namespace(ACPI_TYPE_REGION, sys_bus_handle, ACPI_UINT32_MAX,
> >>>> +                                    acpi_get_iomux_region, NULL, gpio_dev, NULL);
> >>>> +
> >>>> +       if (ACPI_FAILURE(status)) {
> >>>> +               dev_err(&gpio_dev->pdev->dev, "Failed to get acpi_get_iomux_region\n");
> >>>> +               return;
> >>>> +       }
> >>>> +}
> >>> Oh this looks scary to me, make sure you get the review from the GPIO
> >>> ACPI experts, Andy Shevchenko and/or Mika Westerberg. (Added on the
> >>> To: line)
> >> Thanks Linus for the feedback.
> >>
> >> Hi Andy/Mika,
> >>
> >> Please provide your suggestions for this patch.
> > If this is about muxing pins, have you looked at the ACPI PinFunction ()
> > and related descriptors?
> 
> This is about finding below IOMX (pinmux region) from ACPI namespace.

Yes, I know but you use it for muxing pins, no?

> OperationRegion (IOMX, SystemMemory, 0xFED80D00, 0x0100)
> 
> I did not find any other methods to get IOMUX system memory region.

It seems to be standard BAR so simple memory descriptor in _CRS ()
probably works too and does not need any additional lines of code.