Re: [PATCH v2 3/3] pinctrl: amd: Implement pinmux functionality

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

Hi Basavaraj,

thanks for your patch!

On Tue, May 24, 2022 at 9:40 AM Basavaraj Natikar
<Basavaraj.Natikar@xxxxxxx> wrote:
>
> Provide pinmux functionality by implementing pinmux_ops.
>
> Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@xxxxxxx>

This has the same request as patch 1, prefix macros with AMD_*

(...)
> +#define DEFINE_GPIO(_number) static const unsigned int gpio##_number[] = {_number}

Like this

>  #define PINCTRL_GRP(_name, _pins, _npins) \
>         { .name = _name, .pins = _pins, .npins = _npins}

Hm this one was in patch 1, already commented

> +#define PINCTRL_FUNC_GRP(_number) \
> +       [IMX_F0_GPIO##_number] = PINCTRL_GRP("IMX_F0_GPIO"#_number, gpio##_number, 1),\
> +       [IMX_F1_GPIO##_number] = PINCTRL_GRP("IMX_F1_GPIO"#_number, gpio##_number, 1),\
> +       [IMX_F2_GPIO##_number] = PINCTRL_GRP("IMX_F2_GPIO"#_number, gpio##_number, 1),\
> +       [IMX_F3_GPIO##_number] = PINCTRL_GRP("IMX_F3_GPIO"#_number, gpio##_number, 1)

Prefix this one

> +#define PMUX_FUNC(_number, _gname1, _gname2, _gname3, _gname4) {\
> +               .name = "iomux_gpio_"#_number,\
> +               .groups = {"IMX_F0_GPIO"#_number, "IMX_F1_GPIO"#_number,\
> +                          "IMX_F2_GPIO"#_number, "IMX_F3_GPIO"#_number},\
> +               .index = _number,\
> +               .ngroups = NSELECTS }

And this

Apart from that it all looks reasonable to me.

Yours,
Linus Walleij