On Tue, May 17, 2022 at 07:38:19PM +0300, Andy Shevchenko wrote: > +static const struct irq_chip intel_gpio_irq_chip = { > + .name = "intel-gpio", > + .irq_ack = intel_gpio_irq_ack, > + .irq_mask = intel_gpio_irq_mask, > + .irq_unmask = intel_gpio_irq_unmask, > + .irq_set_type = intel_gpio_irq_type, > + .irq_set_wake = intel_gpio_irq_wake, > + .flags = IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_IMMUTABLE, > + GPIOCHIP_IRQ_RESOURCE_HELPERS, > +}; You still have the inconsistent alignment here.