Re: [PATCH v2] drivers: gpio: zevio: drop of_gpio.h header

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Wed, May 11, 2022 at 11:00 PM Moses Christopher Bollavarapu
<mosescb.dev@xxxxxxxxx> wrote:
>
> Remove of_gpio.h header file, replace of_* functions and structs
> with appropriate alternatives.

...

>  V1 -> V2: Move gpio_chip member to top of the struct
>            Use dev_error_probe instead of dev_err
>            Minor style fixes

Almost, see below.

...

> +       controller->regs = devm_platform_ioremap_resource(pdev, 0);
> +       if (IS_ERR(controller->regs))
> +               dev_err_probe(&pdev->dev, PTR_ERR(controller->regs),
> +                             "failed to ioremap memory resource\n");

You forgot 'return'.

-- 
With Best Regards,
Andy Shevchenko