On 2022/5/7 18:54, haibo.chen@xxxxxxx wrote:
From: Haibo Chen <haibo.chen@xxxxxxx> For gpio controller contain register PDDR, when set one target bit, current logic will clear all other bits, this is wrong. Use operator '|=' to fix it.
A fixes tag required, since this is a fix. With fixes tag added: Reviewed-by: Peng Fan <peng.fan@xxxxxxx> Regards, Peng.
Signed-off-by: Haibo Chen <haibo.chen@xxxxxxx> --- drivers/gpio/gpio-vf610.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c index 20780c35da1b..23cddb265a0d 100644 --- a/drivers/gpio/gpio-vf610.c +++ b/drivers/gpio/gpio-vf610.c @@ -125,9 +125,13 @@ static int vf610_gpio_direction_output(struct gpio_chip *chip, unsigned gpio, { struct vf610_gpio_port *port = gpiochip_get_data(chip); unsigned long mask = BIT(gpio); + u32 val;- if (port->sdata && port->sdata->have_paddr)- vf610_gpio_writel(mask, port->gpio_base + GPIO_PDDR); + if (port->sdata && port->sdata->have_paddr) { + val = vf610_gpio_readl(port->gpio_base + GPIO_PDDR); + val |= mask; + vf610_gpio_writel(val, port->gpio_base + GPIO_PDDR); + }vf610_gpio_set(chip, gpio, value);
