On Mon, May 09, 2022 at 05:55:37PM -0700, Colin Foster wrote: > Hmm... So the main reason I needed get_caps was because > phylink_generic_validate looks at mac_capabilities. I know I'll have to > deal with supported_interfaces once I finally get the other four ports > working, but for now the main purpose of this patch is to allow me to > populate the mac_capabilities entry for phylink_generic_validate. > > Aside from ensuring legacy_pre_march2020 = false, I feel like the rest > of the patch makes sense. But still. Just populate mac_capabilities for everybody in the common felix_phylink_get_caps(), and use the generic phylink validation only for your driver.