On Mon, Apr 11, 2022 at 09:23:40AM +0300, Baruch Siach wrote:
> pwmchip_add() unconditionally assigns the base ID dynamically. Commit
> f9a8ee8c8bcd1 ("pwm: Always allocate PWM chip base ID dynamically")
> dropped all base assignment from drivers under drivers/pwm/. It missed
> this driver. Fix that.
>
> Fixes: f9a8ee8c8bcd1 ("pwm: Always allocate PWM chip base ID dynamically")
> Signed-off-by: Baruch Siach <baruch@xxxxxxxxxx>
> ---
> drivers/gpio/gpio-mvebu.c | 7 -------
> 1 file changed, 7 deletions(-)
Linus, Bartosz,
I see that this was Cc'ed to linux-gpio but not to you guys, so I'm not
sure if you're aware of this. Given that this touches the PWM-specific
bits of this driver I could also pick this up into the PWM tree if you
don't mind.
Quoting in full in case you don't have this in your inboxes.
Thierry
> diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
> index 4c1f9e1091b7..a2c8dd329b31 100644
> --- a/drivers/gpio/gpio-mvebu.c
> +++ b/drivers/gpio/gpio-mvebu.c
> @@ -871,13 +871,6 @@ static int mvebu_pwm_probe(struct platform_device *pdev,
> mvpwm->chip.dev = dev;
> mvpwm->chip.ops = &mvebu_pwm_ops;
> mvpwm->chip.npwm = mvchip->chip.ngpio;
> - /*
> - * There may already be some PWM allocated, so we can't force
> - * mvpwm->chip.base to a fixed point like mvchip->chip.base.
> - * So, we let pwmchip_add() do the numbering and take the next free
> - * region.
> - */
> - mvpwm->chip.base = -1;
>
> spin_lock_init(&mvpwm->lock);
>
> --
> 2.35.1
>
Attachment:
signature.asc
Description: PGP signature
