On Sat, Apr 9, 2022 at 1:00 PM YueHaibing <yuehaibing@xxxxxxxxxx> wrote: > If EINT_MTK is m and PINCTRL_MTK_V2 is y, build fails: > > drivers/pinctrl/mediatek/pinctrl-moore.o: In function `mtk_gpio_set_config': > pinctrl-moore.c:(.text+0xa6c): undefined reference to `mtk_eint_set_debounce' > drivers/pinctrl/mediatek/pinctrl-moore.o: In function `mtk_gpio_to_irq': > pinctrl-moore.c:(.text+0xacc): undefined reference to `mtk_eint_find_irq' > > Select EINT_MTK for PINCTRL_MTK_V2 to fix this. > > Fixes: 8174a8512e3e ("pinctrl: mediatek: make MediaTek pinctrl v2 driver ready for buidling loadable module") > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> Good catch! Patch applied for fixes. Yours, Linus Walleij