Re: [PATCH v2] pinctrl: samsung: fix missing GPIOLIB on ARM64 Exynos config

[Arnd Bergmann <arnd@xxxxxxxx>]

On Wed, Apr 20, 2022 at 4:14 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> The Samsung pinctrl drivers depend on OF_GPIO, which is part of GPIOLIB.
> ARMv7 Exynos platform selects GPIOLIB and Samsung pinctrl drivers. ARMv8
> Exynos selects only the latter leading to possible wrong configuration
> on ARMv8 build:
>
>   WARNING: unmet direct dependencies detected for PINCTRL_EXYNOS
>     Depends on [n]: PINCTRL [=y] && OF_GPIO [=n] && (ARCH_EXYNOS [=y] || ARCH_S5PV210 || COMPILE_TEST [=y])
>     Selected by [y]:
>     - ARCH_EXYNOS [=y]
>
> Always select the GPIOLIB from the Samsung pinctrl drivers to fix the
> issue.  This requires removing of OF_GPIO dependency (to avoid recursive
> dependency), so add dependency on OF for COMPILE_TEST cases.
>
> Reported-by: Necip Fazil Yildiran <fazilyildiran@xxxxxxxxx>
> Fixes: eed6b3eb20b9 ("arm64: Split out platform options to separate Kconfig")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Looks good to me,

Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>