On Fri, Apr 15, 2022 at 9:09 AM Andrei Lalaev <andrei.lalaev@xxxxxxxxx> wrote:
> Gpiolib interprets the elements of "gpio-reserved-ranges" as "start,size"
> because it clears "size" bits starting from the "start" bit in the according
> bitmap. So it has to use "greater" instead of "greater or equal" when performs
> bounds check to make sure that GPIOs are in the available range.
> Previous implementation skipped ranges that include the last GPIO in
> the range.
>
> Fixes: 726cb3ba4969 ("gpiolib: Support 'gpio-reserved-ranges' property")
> Signed-off-by: Andrei Lalaev <andrei.lalaev@xxxxxxxxx>
Nice patch!
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Yours,
Linus Walleij
Re: [PATCH v2] gpiolib: of: fix bounds check for 'gpio-reserved-ranges'
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v2] gpiolib: of: fix bounds check for 'gpio-reserved-ranges'
- From: Linus Walleij <linus.walleij@xxxxxxxxxx>
- Date: Tue, 19 Apr 2022 23:53:38 +0200
- In-reply-to: <20220415070710.220785-1-andrei.lalaev@emlid.com>
- References: <20220415070710.220785-1-andrei.lalaev@emlid.com>
- References:
- [PATCH v2] gpiolib: of: fix bounds check for 'gpio-reserved-ranges'
- From: Andrei Lalaev
- [PATCH v2] gpiolib: of: fix bounds check for 'gpio-reserved-ranges'
- Prev by Date: Re: [PATCH v5 0/6] gpiolib: more helpers and fwnode conversion
- Next by Date: Re: [PATCH v2 00/10] gpiolib: Handle immutable irq_chip structures
- Previous by thread: Re: [PATCH v2] gpiolib: of: fix bounds check for 'gpio-reserved-ranges'
- Next by thread: Re: [PATCH v2] gpiolib: of: fix bounds check for 'gpio-reserved-ranges'
- Index(es):
 |