On Mon, Apr 11, 2022 at 12:57 PM Andrei Lalaev <andrei.lalaev@xxxxxxxxx> wrote: > > Use "greater" instead of "greater or equal" when performs bounds check > to make sure that GPIOS are in available range. Previous implementation the available > skipped ranges which include last GPIO in range. the last Should it have a Fixes tag? OTOH, the current implementation suggests that we have start,end rather than start,count. What does documentation tell about it? Does it need to be fixed? -- With Best Regards, Andy Shevchenko
Re: [PATCH] gpiolib: of: fix bounds check for valid mask
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] gpiolib: of: fix bounds check for valid mask
- From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
- Date: Mon, 11 Apr 2022 15:12:57 +0300
- In-reply-to: <20220411063324.98542-1-andrei.lalaev@emlid.com>
- References: <20220411063324.98542-1-andrei.lalaev@emlid.com>
- Follow-Ups:
- Re: [PATCH] gpiolib: of: fix bounds check for valid mask
- From: Bartosz Golaszewski
- Re: [PATCH] gpiolib: of: fix bounds check for valid mask
- From: Andrei Lalaev
- Re: [PATCH] gpiolib: of: fix bounds check for valid mask
- References:
- [PATCH] gpiolib: of: fix bounds check for valid mask
- From: Andrei Lalaev
- [PATCH] gpiolib: of: fix bounds check for valid mask
- Prev by Date: Re: [PATCH v4 05/13] pinctrl: samsung: Switch to use for_each_gpiochip_node() helper
- Next by Date: Re: [PATCH v4 05/13] pinctrl: samsung: Switch to use for_each_gpiochip_node() helper
- Previous by thread: Re: [PATCH] gpiolib: of: fix bounds check for valid mask
- Next by thread: Re: [PATCH] gpiolib: of: fix bounds check for valid mask
- Index(es):
 |