Re: [PATCH] API: rename gpiod_chip_find_line()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 05, 2022 at 09:44:24PM +0800, Kent Gibson wrote:
> On Tue, Apr 05, 2022 at 03:21:58PM +0200, Bartosz Golaszewski wrote:
> > The name "find_line" is quite ambigous. We should indicate that the
> > purpose of this routine is to map the line name to its HW offset.
> > Kent suggested get_line_get_offset_from_name() which is hard to beat
> > when it comes to being explicit.
> > 
> 
> My suggestion was actually gpiod_chip_line_offset_from_name().
> But gpiod_chip_get_line_offset_from_name() is even more explicit.
> And both make more sense than your misquote above ;-).
> 
> So that works for me - assuming you fix the quote.

I also like this. Thanks!

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux