RE: [PATCH] pinctrl: samsung: staticize fsd_pin_ctrl

["Alim Akhtar" <alim.akhtar@xxxxxxxxxxx>]

>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx]
>Sent: Friday, April 1, 2022 1:15 AM
>To: Tomasz Figa <tomasz.figa@xxxxxxxxx>; Krzysztof Kozlowski
><krzk@xxxxxxxxxx>; Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>; Alim
>Akhtar <alim.akhtar@xxxxxxxxxxx>; Linus Walleij <linus.walleij@xxxxxxxxxx>;
>Ajay Kumar <ajaykumar.rs@xxxxxxxxxxx>; linux-arm-
>kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; linux-
>gpio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>; kernel test robot
><lkp@xxxxxxxxx>
>Subject: [PATCH] pinctrl: samsung: staticize fsd_pin_ctrl
>
>struct fsd_pin_ctrl is not used outside of the file, so it can be made
static.  This
>fixes sparse warning:
>
>  drivers/pinctrl/samsung/pinctrl-exynos-arm64.c:773:31: sparse:
>    symbol 'fsd_pin_ctrl' was not declared. Should it be static?
>
>Reported-by: kernel test robot <lkp@xxxxxxxxx>
>Fixes: 0d1b662c374c ("pinctrl: samsung: add FSD SoC specific data")
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>---

Thanks Krzysztof.

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

> drivers/pinctrl/samsung/pinctrl-exynos-arm64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c
>b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c
>index d291819c2f77..cb965cf93705 100644
>--- a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c
>+++ b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c
>@@ -770,7 +770,7 @@ static const struct samsung_pin_bank_data
>fsd_pin_banks2[] __initconst = {
> 	EXYNOS850_PIN_BANK_EINTN(3, 0x00, "gpq0"),  };
>
>-const struct samsung_pin_ctrl fsd_pin_ctrl[] __initconst = {
>+static const struct samsung_pin_ctrl fsd_pin_ctrl[] __initconst = {
> 	{
> 		/* pin-controller instance 0 FSYS0 data */
> 		.pin_banks	= fsd_pin_banks0,
>--
>2.32.0