Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on a67ba3cf9551f8c92d5ec9d7eae1aadbb9127b57] url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/gpiolib-Two-new-helpers-and-way-toward-fwnode/20220330-225341 base: a67ba3cf9551f8c92d5ec9d7eae1aadbb9127b57 config: arm-randconfig-c002-20220331 (https://download.01.org/0day-ci/archive/20220401/202204010610.Wk5CAkQ7-lkp@xxxxxxxxx/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 881350a92d821d4f8e4fa648443ed1d17e251188) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/intel-lab-lkp/linux/commit/3539d23dd289ca77a85d66fe8721e4febfc50ea4 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Andy-Shevchenko/gpiolib-Two-new-helpers-and-way-toward-fwnode/20220330-225341 git checkout 3539d23dd289ca77a85d66fe8721e4febfc50ea4 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> drivers/pinctrl/samsung/pinctrl-exynos.c:310:50: error: no member named 'of_node' in 'struct samsung_pin_bank'; did you mean 'fwnode'? bank->irq_domain = irq_domain_add_linear(bank->of_node, ^~~~~~~ fwnode drivers/pinctrl/samsung/pinctrl-samsung.h:168:24: note: 'fwnode' declared here struct fwnode_handle *fwnode; ^ drivers/pinctrl/samsung/pinctrl-exynos.c:568:50: error: no member named 'of_node' in 'struct samsung_pin_bank'; did you mean 'fwnode'? bank->irq_domain = irq_domain_add_linear(bank->of_node, ^~~~~~~ fwnode drivers/pinctrl/samsung/pinctrl-samsung.h:168:24: note: 'fwnode' declared here struct fwnode_handle *fwnode; ^ drivers/pinctrl/samsung/pinctrl-exynos.c:576:31: error: no member named 'of_node' in 'struct samsung_pin_bank'; did you mean 'fwnode'? if (!of_find_property(bank->of_node, "interrupts", NULL)) { ^~~~~~~ fwnode drivers/pinctrl/samsung/pinctrl-samsung.h:168:24: note: 'fwnode' declared here struct fwnode_handle *fwnode; ^ drivers/pinctrl/samsung/pinctrl-exynos.c:591:37: error: no member named 'of_node' in 'struct samsung_pin_bank'; did you mean 'fwnode'? irq = irq_of_parse_and_map(bank->of_node, idx); ^~~~~~~ fwnode drivers/pinctrl/samsung/pinctrl-samsung.h:168:24: note: 'fwnode' declared here struct fwnode_handle *fwnode; ^ 4 errors generated. vim +310 drivers/pinctrl/samsung/pinctrl-exynos.c 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 273 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 274 /* 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 275 * exynos_eint_gpio_init() - setup handling of external gpio interrupts. 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 276 * @d: driver data of samsung pinctrl driver. 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 277 */ 85745c870a757c drivers/pinctrl/samsung/pinctrl-exynos.c Marek Szyprowski 2020-07-20 278 __init int exynos_eint_gpio_init(struct samsung_pinctrl_drv_data *d) 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 279 { 595be7268a8573 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2012-10-11 280 struct samsung_pin_bank *bank; 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 281 struct device *dev = d->dev; 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 282 int ret; 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 283 int i; 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 284 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 285 if (!d->irq) { 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 286 dev_err(dev, "irq number not available\n"); 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 287 return -EINVAL; 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 288 } 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 289 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 290 ret = devm_request_irq(dev, d->irq, exynos_eint_gpio_irq, 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 291 0, dev_name(dev), d); 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 292 if (ret) { 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 293 dev_err(dev, "irq request failed\n"); 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 294 return -ENXIO; 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 295 } 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 296 1bf00d7a6dbff0 drivers/pinctrl/samsung/pinctrl-exynos.c Tomasz Figa 2014-09-23 297 bank = d->pin_banks; 1bf00d7a6dbff0 drivers/pinctrl/samsung/pinctrl-exynos.c Tomasz Figa 2014-09-23 298 for (i = 0; i < d->nr_banks; ++i, ++bank) { 595be7268a8573 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2012-10-11 299 if (bank->eint_type != EINT_TYPE_GPIO) 595be7268a8573 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2012-10-11 300 continue; 85745c870a757c drivers/pinctrl/samsung/pinctrl-exynos.c Marek Szyprowski 2020-07-20 301 85745c870a757c drivers/pinctrl/samsung/pinctrl-exynos.c Marek Szyprowski 2020-07-20 302 bank->irq_chip = devm_kmemdup(dev, &exynos_gpio_irq_chip, 85745c870a757c drivers/pinctrl/samsung/pinctrl-exynos.c Marek Szyprowski 2020-07-20 303 sizeof(*bank->irq_chip), GFP_KERNEL); 85745c870a757c drivers/pinctrl/samsung/pinctrl-exynos.c Marek Szyprowski 2020-07-20 304 if (!bank->irq_chip) { 85745c870a757c drivers/pinctrl/samsung/pinctrl-exynos.c Marek Szyprowski 2020-07-20 305 ret = -ENOMEM; 85745c870a757c drivers/pinctrl/samsung/pinctrl-exynos.c Marek Szyprowski 2020-07-20 306 goto err_domains; 85745c870a757c drivers/pinctrl/samsung/pinctrl-exynos.c Marek Szyprowski 2020-07-20 307 } 85745c870a757c drivers/pinctrl/samsung/pinctrl-exynos.c Marek Szyprowski 2020-07-20 308 bank->irq_chip->chip.name = bank->name; 85745c870a757c drivers/pinctrl/samsung/pinctrl-exynos.c Marek Szyprowski 2020-07-20 309 595be7268a8573 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2012-10-11 @310 bank->irq_domain = irq_domain_add_linear(bank->of_node, 6f5e41bd8fc6d3 drivers/pinctrl/samsung/pinctrl-exynos.c Abhilash Kesavan 2014-10-09 311 bank->nr_pins, &exynos_eint_irqd_ops, bank); 595be7268a8573 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2012-10-11 312 if (!bank->irq_domain) { 595be7268a8573 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2012-10-11 313 dev_err(dev, "gpio irq domain add failed\n"); 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 314 ret = -ENXIO; 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 315 goto err_domains; 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 316 } 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 317 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 318 bank->soc_priv = devm_kzalloc(d->dev, 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 319 sizeof(struct exynos_eint_gpio_save), GFP_KERNEL); 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 320 if (!bank->soc_priv) { 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 321 irq_domain_remove(bank->irq_domain); 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 322 ret = -ENOMEM; 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 323 goto err_domains; 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 324 } 0d3d30db936359 drivers/pinctrl/samsung/pinctrl-exynos.c Abhilash Kesavan 2014-10-09 325 595be7268a8573 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2012-10-11 326 } 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 327 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 328 return 0; 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 329 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 330 err_domains: 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 331 for (--i, --bank; i >= 0; --i, --bank) { 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 332 if (bank->eint_type != EINT_TYPE_GPIO) 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 333 continue; 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 334 irq_domain_remove(bank->irq_domain); 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 335 } 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 336 7ccbc60cd9c293 drivers/pinctrl/pinctrl-exynos.c Tomasz Figa 2013-05-22 337 return ret; 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 338 } 43b169db184184 drivers/pinctrl/pinctrl-exynos.c Thomas Abraham 2012-09-07 339 -- 0-DAY CI Kernel Test Service https://01.org/lkp
Re: [PATCH v3 05/13] pinctrl: samsung: Switch to use for_each_gpiochip_node() helper
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v3 05/13] pinctrl: samsung: Switch to use for_each_gpiochip_node() helper
- From: kernel test robot <lkp@xxxxxxxxx>
- Date: Fri, 1 Apr 2022 06:31:10 +0800
- In-reply-to: <20220330145030.1562-6-andriy.shevchenko@linux.intel.com>
- References: <20220330145030.1562-6-andriy.shevchenko@linux.intel.com>
- User-agent: Mutt/1.10.1 (2018-07-13)
- References:
- [PATCH v3 05/13] pinctrl: samsung: Switch to use for_each_gpiochip_node() helper
- From: Andy Shevchenko
- [PATCH v3 05/13] pinctrl: samsung: Switch to use for_each_gpiochip_node() helper
- Prev by Date: [PATCH] pinctrl: samsung: staticize fsd_pin_ctrl
- Next by Date: Re: gpiolib: why does gpio_set_bias() suppress ENOTSUPP?
- Previous by thread: Re: [PATCH v3 05/13] pinctrl: samsung: Switch to use for_each_gpiochip_node() helper
- Next by thread: [PATCH v3 06/13] pinctrl: renesas: rza1: Replace custom code by gpiochip_node_count() call
- Index(es):
 |