Re: [PATCH] dt-bindings: gpio: add common consumer GPIO lines

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On Sat, 26 Mar 2022 at 01:28, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Tue, Mar 15, 2022 at 9:37 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxxxxx> wrote:
>
> > Typical GPIO lines like enable, powerdown, reset or wakeup are not
> > documented as common, which leads to new variations of these (e.g.
> > pwdn-gpios).  Add a common schema which serves also as a documentation
> > for preferred naming.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
>
> I like the idea!
>
> > +  enable-gpios:
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > +
> > +  reset-gpios:
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > +
> > +  powerdown-gpios:
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > +
> > +  pwdn-gpios:
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > +    description: Use powerdown-gpios
> > +    deprecated: true
> > +
> > +  wakeup-gpios:
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
>
> I would underscore either on each one or in a global description:
> that lines on components that indicate they are active low
> such as RESETN, RESET* etc MUST have the flag in the
> second cell set to GPIO_ACTIVE_LOW.

Sure, I'll add it.

Best regards,
Krzysztof