Re: [linusw-pinctrl:for-next] BUILD REGRESSION 0c3c8458428ab471178a0d155222eaa62083d033

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Wed, Mar 23, 2022 at 5:46 PM Jonathan Neuschäfer
<j.neuschaefer@xxxxxxx> wrote:
> Me
> > Do you think you could run sparse over the drivers in some way and check
> > what else needs to be fixed?
>
> I ran "make C=1" on drivers/pinctrl/nuvoton now, and only noticed the
> same array initializer syntax warning as in pinctrl-wpcm450, in pinctrl-npcm7xx.

OK I'll just augment it to fix that in the same patch.

> > > drivers/pinctrl/nuvoton/pinctrl-wpcm450.c:470:26: error: array type has incomplete element type 'struct group_desc'
> > > drivers/pinctrl/nuvoton/pinctrl-wpcm450.c:470:40: error: array has incomplete element type 'struct group_desc'
> > > drivers/pinctrl/nuvoton/pinctrl-wpcm450.c:824:56: warning: parameter 'selector' set but not used [-Wunused-but-set-parameter]
> > > drivers/pinctrl/nuvoton/pinctrl-wpcm450.c:888:48: warning: parameter 'group' set but not used [-Wunused-but-set-parameter]
>
> This bunch was fixed with my patch "pinctrl: nuvoton: wpcm450: select
> GENERIC_PINCTRL_GROUPS". There are also two more fixes sent by Jialin
> Zhang and Dan Carpenter over the past week.

Excellent, applied the fix!

Let's see about the last one.

Yours,
Linus Walleij