Re: [PATCH] gpio: Drop CONFIG_DEBUG_GPIO

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Tue, Mar 22, 2022 at 4:49 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> On Tue, Mar 22, 2022 at 3:38 PM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Fri, Mar 11, 2022 at 4:55 AM Brian Norris <briannorris@xxxxxxxxxxxx> wrote:
> >
> > ...
> >
> > > Description: it says nothing about enabling extra printk()s. But -DDEBUG
> > > does just that; it turns on every dev_dbg()/pr_debug() that would
> > > otherwise be silent.
> >
> > Which is what some and I are using a lot during development.
> >
>
> AFAIK this: https://www.kernel.org/doc/local/pr_debug.txt is the right
> way to do it?

Yes. But it means we need to have a separate option on a per driver
(or group of drivers) basis. I don't think it's a good idea right now.

> https://www.kernel.org/doc/local/pr_debug.txt
>
> This doesn't mention adding Kconfig options just to enable debug messages.
>
> > ...
> >
> > > -ccflags-$(CONFIG_DEBUG_GPIO)   += -DDEBUG
> > > -
> >
> > NAK to this change.
> >
> > I'm not against enabling might_sleep() unconditionally.
> >
>
> These are already controlled by CONFIG_DEBUG_ATOMIC_SLEEP, no? Or
> maybe I can't parse that double negation.

The part of the patch that converts might_sleep_if():s is fine with me.

-- 
With Best Regards,
Andy Shevchenko