Re: [PATCH] gpio: Drop CONFIG_DEBUG_GPIO

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Brian,

On Tue, Mar 15, 2022 at 1:19 AM Brian Norris <briannorris@xxxxxxxxxxxx> wrote:
> On Mon, Mar 14, 2022 at 3:23 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> > On Mon, Mar 14, 2022 at 4:00 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> > > I like it. It's true we don't see many of those DEBUG constructs
> > > anymore nowadays and overhead for might_sleep() and WARN_ON() is
> > > negligible.
> >
> > I agree.  I have something similar for pinctrl, maybe that needs to
> > go too.
>
> Huh, yeah, CONFIG_DEBUG_PINCTRL does look awfully similar, and I just
> didn't notice because we don't happen to have it enabled for Chromium
> kernels. We happen to have CONFIG_DEBUG_GPIO enabled though, and the
> "new" rockchip-gpio log messages triggered me :)
>
> I guess one difference is that CONFIG_DEBUG_PINCTRL is almost
> exclusively (aside from some renesas drivers?) about extra logging and
> less about interesting checks that one might want to enable in more
> general settings. So it's a clearer call to make that people generally
> want it disabled.

For the Renesas pinctrl drivers, it enables sanity checks on the pin
control tables, which you definitely do not want in your production
kernel.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds