Re: [PATCH v2] gpio: Restrict usage of gc irq members before initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 15, 2022 at 7:38 PM kernel test robot <lkp@xxxxxxxxx> wrote:
>
> Hi Shreeya,
>
> Thank you for the patch! Yet something to improve:


> All errors (new ones prefixed by >>):
>
>    drivers/gpio/gpiolib.c: In function 'gpiod_to_irq':
> >> drivers/gpio/gpiolib.c:3068:29: error: 'struct gpio_chip' has no member named 'irq'
>     3068 |         if (gc->to_irq && gc->irq.gc_irq_initialized) {
>          |                             ^~

Exactly, because this check should go under ifdeffery.

-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux