On Thu, Feb 24, 2022 at 5:36 AM Srinivas Neeli <srinivas.neeli@xxxxxxxxxx> wrote: > module_platform_driver() makes the code simpler by eliminating > boilerplate code. > > Signed-off-by: Srinivas Neeli <srinivas.neeli@xxxxxxxxxx> Nice, patch applied! > -static int __init zynq_pinctrl_init(void) > -{ > - return platform_driver_register(&zynq_pinctrl_driver); > -} > -arch_initcall(zynq_pinctrl_init); > +module_platform_driver(zynq_pinctrl_driver); This will incidentally also move the initcall from arch_initcall to driver_initcall but I assume that works so, OK. Yours, Linus Walleij