Re: [PATCH 2/5] platform/x86: x86-android-tablets: Fix EBUSY error when requesting IOAPIC IRQs

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>]

On Wed, Feb 23, 2022 at 04:16:42PM +0100, Hans de Goede wrote:
> On 2/23/22 15:56, Andy Shevchenko wrote:
> > On Wed, Feb 23, 2022 at 02:31:50PM +0100, Hans de Goede wrote:

...

> >>  	case X86_ACPI_IRQ_TYPE_APIC:
> >> +		/*
> >> +		 * The DSDT may already reference the GSI in a device skipped by
> >> +		 * acpi_quirk_skip_i2c_client_enumeration(). Unregister the GSI
> >> +		 * to avoid EBUSY errors in this case.
> >> +		 */
> >> +		acpi_unregister_gsi(data->index);
> > 
> > Perhaps a warning (or at least debug) message?
> 
> The function returns void, so we cannot check if it did anything or not.

Another approach may be to try to register GSI and if fail, try unregister
and register again?

-- 
With Best Regards,
Andy Shevchenko