On Wed, Feb 23, 2022 at 08:12:49AM +0100, Krzysztof Kozlowski wrote: > On 23/02/2022 07:20, Uwe Kleine-König wrote: > > On Mon, Feb 14, 2022 at 01:58:35PM +0000, conor.dooley@xxxxxxxxxxxxx wrote: > >> From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > >> > >> Add device tree bindings for the Microchip fpga fabric based "core" PWM > >> controller. > >> > >> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > >> Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > >> Acked-by: Palmer Dabbelt <palmer@xxxxxxxxxxxx> > > > > I like it: > > > > Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > > > nitpick: Put your S-o-b last in the commit log. (This doesn't justify a > > resend IMHO) > > It should be the opposite - the first. First author signs the patch, > then comes review and finally an ack. Putting SoB at then suggests that > tags were accumulated before sending patch, out of mailing list. well, or in an earlier revision of this patch as is the case here. One of the ideas of S-o-b is that the order shows the flow of the patch states and if this patch ends in git with: Referred-by: Rob Herring <robh@xxxxxxxxxx> Singed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Backed-by: Palmer Dabbelt <palmer@xxxxxxxxxxxx> Singed-off-by: Peter Maintainer <pm@xxxxxxxxxxx> I'd expect that Backed-by was added by Peter, not Conor. (Modified the tags on purpose to not interfere with b4's tag pickup, I guess you humans still get the point.) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
