Re: [PATCH] pinctrl: sh-pfc: checker: Fix miscalculation of number of states

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Mon, Feb 21, 2022 at 5:22 PM Geert Uytterhoeven
<geert+renesas@xxxxxxxxx> wrote:

> The checker failed to validate all enum IDs in the description of a
> register with fixed-width register fields, due to a miscalculation of
> the number of described states: each register field of n bits can have
> "1 << n" possible states, not "1".
>
> Increase SH_PFC_MAX_ENUMS accordingly, now more enum IDs are checked
> (SH-Mobile AG5 has more than 4000 enum IDs defined).
>
> Fixes: 12d057bad683b1c6 ("pinctrl: sh-pfc: checker: Add check for enum ID conflicts")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> To be queued in renesas-pinctrl-for-v5.18.

I certainly trust you to generally do what is best for the Renesas drivers.

I have a question about this checker infrastructure because it is obviously
a piece of really valuable code for Renesas.

How general is this checker? Do we have other drivers in the kernel that
would benefit from it or is it completely Renesas-specific?

If it has general value I think it should be moved to be one floor down,
with the pinctrl framework, if possible. But I don't know the details.

Yours,
Linus Walleij