On Fri, Feb 4, 2022 at 2:02 PM Niklas Cassel <Niklas.Cassel@xxxxxxx> wrote: > From: Niklas Cassel <niklas.cassel@xxxxxxx> Hi Niklas, long time no C! > Setting the output of a GPIO to 1 using gpiod_set_value(), followed by > reading the same GPIO using gpiod_get_value(), will currently yield an > incorrect result. > > This is because the SiFive GPIO device stores the output values in reg_set, > not reg_dat. > > Supply the flag BGPIOF_READ_OUTPUT_REG_SET to bgpio_init() so that the > generic driver reads the correct register. > > Signed-off-by: Niklas Cassel <niklas.cassel@xxxxxxx> Looks like a straight-forward fix so: Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij
Re: [PATCH] gpio: sifive: use the correct register to read output values
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] gpio: sifive: use the correct register to read output values
- From: Linus Walleij <linus.walleij@xxxxxxxxxx>
- Date: Sat, 5 Feb 2022 17:39:35 +0100
- In-reply-to: <20220204130142.21727-1-Niklas.Cassel@wdc.com>
- References: <20220204130142.21727-1-Niklas.Cassel@wdc.com>
- Follow-Ups:
- Re: [PATCH] gpio: sifive: use the correct register to read output values
- From: Niklas Cassel
- Re: [PATCH] gpio: sifive: use the correct register to read output values
- References:
- [PATCH] gpio: sifive: use the correct register to read output values
- From: Niklas Cassel
- [PATCH] gpio: sifive: use the correct register to read output values
- Prev by Date: [PATCH v3 1/2] pinctrl: nuvoton: npcm7xx: Use %zu printk format for ARRAY_SIZE()
- Next by Date: [RESEND v8 1/2] dt-bindings: gpio-cascade: add documentation
- Previous by thread: Re: [PATCH] gpio: sifive: use the correct register to read output values
- Next by thread: Re: [PATCH] gpio: sifive: use the correct register to read output values
- Index(es):
 |