Re: [PATCH] gpio: sim: check the label length when setting up device properties

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Thu, Jan 20, 2022 at 11:18 PM Kent Gibson <warthog618@xxxxxxxxx> wrote:
>
> On Thu, Jan 20, 2022 at 08:49:48PM +0100, Bartosz Golaszewski wrote:
> > If the user-space sets the chip label to an empty string - we should
> > check the length and assign the default name or otherwise line hogs
> > will not be properly attached.
> >
>
> "assign" -> "not override"?
>
> Cheers,
> Kent.
>
> > Fixes: cb8c474e79be ("gpio: sim: new testing module")
> > Signed-off-by: Bartosz Golaszewski <brgl@xxxxxxxx>
> > ---
> >  drivers/gpio/gpio-sim.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> > index 838bbfed11d3..04b137eca8da 100644
> > --- a/drivers/gpio/gpio-sim.c
> > +++ b/drivers/gpio/gpio-sim.c
> > @@ -816,7 +816,7 @@ gpio_sim_make_bank_swnode(struct gpio_sim_bank *bank,
> >
> >       properties[prop_idx++] = PROPERTY_ENTRY_U32("ngpios", bank->num_lines);
> >
> > -     if (bank->label)
> > +     if (bank->label && (strlen(bank->label) > 0))
> >               properties[prop_idx++] = PROPERTY_ENTRY_STRING("gpio-sim,label",
> >                                                              bank->label);
> >
> > --
> > 2.30.1
> >

Fixed when applying.

Bart