Re: [PATCH] gpio: idt3243x: Fix signedness bug in probe

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Thu, Jan 20, 2022 at 6:20 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> The "parent_irq" variable needs to be signed for the error handling to
> work.
>
> Fixes: 30fee1d7462a ("gpio: idt3243x: Fix IRQ check in idt_gpio_probe")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
>  drivers/gpio/gpio-idt3243x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-idt3243x.c b/drivers/gpio/gpio-idt3243x.c
> index 08493b05be2d..52b8b72ded77 100644
> --- a/drivers/gpio/gpio-idt3243x.c
> +++ b/drivers/gpio/gpio-idt3243x.c
> @@ -132,7 +132,7 @@ static int idt_gpio_probe(struct platform_device *pdev)
>         struct device *dev = &pdev->dev;
>         struct gpio_irq_chip *girq;
>         struct idt_gpio_ctrl *ctrl;
> -       unsigned int parent_irq;
> +       int parent_irq;
>         int ngpios;
>         int ret;
>
> --
> 2.20.1
>

Hi Dan!

Fixes for this and the same issue in mpc8xxx have already been fixed by Yang Li.

Bart