On Sun, Jan 9, 2022 at 2:13 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Fri, Jan 7, 2022 at 7:34 AM Cosmin Tanislav <demonsingur@xxxxxxxxx> wrote: > > + bitmap_zero(bits, chip->ngpio); > (At least this conditional can be replaced with __asign_bit() call, > but I think refactoring the entire loop may reveal a better approach) Switching to it makes bitmap_zero() redundant. -- With Best Regards, Andy Shevchenko
Re: [PATCH 3/3] iio: addac: ad74413r: correct comparator gpio getters mask usage
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 3/3] iio: addac: ad74413r: correct comparator gpio getters mask usage
- From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
- Date: Sun, 9 Jan 2022 14:14:06 +0200
- In-reply-to: <CAHp75Vcq76iaHHp2oXFsaE4d_+EGH87DxQRYu7Ys-adN_4mmUw@mail.gmail.com>
- References: <20220106062255.3208817-1-cosmin.tanislav@analog.com> <20220106062255.3208817-3-cosmin.tanislav@analog.com> <CAHp75Vcq76iaHHp2oXFsaE4d_+EGH87DxQRYu7Ys-adN_4mmUw@mail.gmail.com>
- References:
- [PATCH 1/3] iio: addac: ad74413r: use ngpio size when iterating over mask
- From: Cosmin Tanislav
- [PATCH 3/3] iio: addac: ad74413r: correct comparator gpio getters mask usage
- From: Cosmin Tanislav
- Re: [PATCH 3/3] iio: addac: ad74413r: correct comparator gpio getters mask usage
- From: Andy Shevchenko
- [PATCH 1/3] iio: addac: ad74413r: use ngpio size when iterating over mask
- Prev by Date: Re: [PATCH 3/3] iio: addac: ad74413r: correct comparator gpio getters mask usage
- Next by Date: [PATCH v4 1/9] dt-bindings: arm/npcm: Add binding for global control registers (GCR)
- Previous by thread: Re: [PATCH 3/3] iio: addac: ad74413r: correct comparator gpio getters mask usage
- Next by thread: Re: [PATCH 3/3] iio: addac: ad74413r: correct comparator gpio getters mask usage
- Index(es):
 |