Re: [PATCH V3] pinctrl: bcm: ns: use generic groups & functions helpers

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Wed, Dec 22, 2021 at 7:43 AM Rafał Miłecki <zajec5@xxxxxxxxx> wrote:

> From: Rafał Miłecki <rafal@xxxxxxxxxx>
>
> This simplifies ns driver and gets rid of ~70 lines of code.
>
> "const" had to be dropped from "struct ns_pinctrl_group" @pins to match
> "struct group_desc" @pins and pinctrl_generic_add_group(). Otherwise it
> would cause:
>
> drivers/pinctrl/bcm/pinctrl-ns.c: In function 'ns_pinctrl_probe':
> drivers/pinctrl/bcm/pinctrl-ns.c:277:13: warning: passing argument 3 of 'pinctrl_generic_add_group' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>   277 |        group->pins, group->num_pins, NULL);
>       |        ~~~~~^~~~~~
>
> Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>

This v3 version applied, nice work!

Yours,
Linus Walleij