Re: [PATCH] pinctrl: imx: fix allocation result check

[Fabio Estevam <festevam@xxxxxxxxx>]

On Thu, Dec 23, 2021 at 4:56 AM Abel Vesa <abel.vesa@xxxxxxx> wrote:
>
> On 21-12-22 22:28:07, Rafał Miłecki wrote:
> > From: Rafał Miłecki <rafal@xxxxxxxxxx>
> >
> > Fix code to check correct variable value.
> >
> > Reported-by: Abel Vesa <abel.vesa@xxxxxxx>
>
> Reviewed-by: Abel Vesa <abel.vesa@xxxxxxx>

After applying this fix, I can boot an imx7s-warp board on linux-next,
but there are
several "invalid group" errors:

# dmesg | grep pinctrl
[    0.072510] pinctrl core: initialized pinctrl subsystem
[    0.169977] imx7d-pinctrl 302c0000.iomuxc-lpsr: initialized IMX
pinctrl driver
[    0.176003] imx7d-pinctrl 30330000.pinctrl: initialized IMX pinctrl driver
[    0.379887] imx7d-pinctrl 30330000.pinctrl: invalid group
"brcmreggrp" for function "pinctrl"
[    0.381957] imx7d-pinctrl 30330000.pinctrl: invalid group
"btreggrp" for function "pinctrl"
[    0.399802] imx7d-pinctrl 30330000.pinctrl: invalid group "i2c1grp"
for function "pinctrl"
[    0.405120] imx7d-pinctrl 30330000.pinctrl: invalid group "i2c2grp"
for function "pinctrl"
[    0.414204] imx7d-pinctrl 30330000.pinctrl: invalid group "i2c3grp"
for function "pinctrl"
[    0.416103] imx7d-pinctrl 30330000.pinctrl: invalid group "i2c4grp"
for function "pinctrl"
[    2.552967] imx7d-pinctrl 30330000.pinctrl: invalid group
"uart1grp" for function "pinctrl"
[    3.527187] imx7d-pinctrl 30330000.pinctrl: invalid group
"uart3grp" for function "pinctrl"
[    3.548179] imx7d-pinctrl 30330000.pinctrl: invalid group
"uart6grp" for function "pinctrl"
[    3.923545] imx7d-pinctrl 30330000.pinctrl: invalid group
"usdhc1grp" for function "pinctrl"
[    3.949302] imx7d-pinctrl 30330000.pinctrl: invalid group
"usdhc3grp" for function "pinctrl"
[    3.958183] imx7d-pinctrl 30330000.pinctrl: invalid group
"usdhc3grp_100mhz" for function "pinctrl"
[    4.657275] imx7d-pinctrl 30330000.pinctrl: invalid group
"sai1mclkgrp" for function "pinctrl"
[    5.201507] imx7d-pinctrl 30330000.pinctrl: invalid group "sai1grp"
for function "pinctrl"
[    5.866850] imx7d-pinctrl 30330000.pinctrl: invalid group "sai1grp"
for function "pinctrl"
[    5.889662] imx7d-pinctrl 30330000.pinctrl: invalid group "sai1grp"
for function "pinctrl"
[    5.907229] imx7d-pinctrl 30330000.pinctrl: invalid group "gpiogrp"
for function "pinctrl"
[    5.936451] imx7d-pinctrl 30330000.pinctrl: invalid group "sai1grp"
for function "pinctrl"