Re: [PATCH v9 3/6] dt-bindings: reset: Add Delta TN48M

[Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>]

Hi Robert,

On Wed, 2021-12-01 at 22:28 +0100, Robert Marko wrote:
> On Tue, Nov 9, 2021 at 12:32 PM Robert Marko <robert.marko@xxxxxxxxxx> wrote:
> > 
> > Add header for the Delta TN48M CPLD provided
> > resets.
> > 
> > Signed-off-by: Robert Marko <robert.marko@xxxxxxxxxx>
> > ---
> >  include/dt-bindings/reset/delta,tn48m-reset.h | 20 +++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >  create mode 100644 include/dt-bindings/reset/delta,tn48m-reset.h
> > 
> > diff --git a/include/dt-bindings/reset/delta,tn48m-reset.h b/include/dt-bindings/reset/delta,tn48m-reset.h
> > new file mode 100644
> > index 000000000000..d4e9ed12de3e
> > --- /dev/null
> > +++ b/include/dt-bindings/reset/delta,tn48m-reset.h
> > @@ -0,0 +1,20 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +/*
> > + * Delta TN48M CPLD GPIO driver
> > + *
> > + * Copyright (C) 2021 Sartura Ltd.
> > + *
> > + * Author: Robert Marko <robert.marko@xxxxxxxxxx>
> > + */
> > +
> > +#ifndef _DT_BINDINGS_RESET_TN48M_H
> > +#define _DT_BINDINGS_RESET_TN48M_H
> > +
> > +#define CPU_88F7040_RESET      0
> > +#define CPU_88F6820_RESET      1
> > +#define MAC_98DX3265_RESET     2
> > +#define PHY_88E1680_RESET      3
> > +#define PHY_88E1512_RESET      4
> > +#define POE_RESET              5
> > +
> > +#endif /* _DT_BINDINGS_RESET_TN48M_H */
> > --
> > 2.33.1
> > 
> 
> Does anybody have any comments on the patch as the reset driver got reviewed and
> the bindings have not?

Not much to review here, I can't tell if the indices are correct.

Acked-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>

To be merged with the rest of the series. Or do you want me to pick up
the reset parts individually? In that case you'd have to split out the
reset bindings into a separate patch.


regards
Philipp